[IMP] account: Allow searching on amount in move lines #4798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:18.0-rd-accounting-onboarding-malb, it needs to be retargeted before it can be merged. |
malb-odoo
reviewed
Jul 2, 2025
| '|', '|', '|', | ||
| ('name', 'ilike', self), ('ref', 'ilike', self), ('account_id', 'ilike', self), ('partner_id', 'ilike', self)]"/> | ||
| '|', '|', '|', '|', '|', '|', | ||
| ('debit', 'ilike', self), ('credit', 'ilike', self), ('balance', 'ilike', self), ('name', 'ilike', self), ('ref', 'ilike', self), ('account_id', 'ilike', self), ('partner_id', 'ilike', self)]"/> |
There was a problem hiding this comment.
to follow the functional need create a new filter call Amount 😄
There was a problem hiding this comment.
@malb-odoo Done, thanks for the review!
mograby3500
force-pushed
the
18.0-rd-accounting-onboarding-allow-search-on-amount-in-move-line-alah
branch
from
ee83a4f to
b97a185
Compare
malb-odoo
reviewed
Jul 3, 2025
| @@ -305,6 +305,8 @@ | |||
| <field name="name" string="Journal Item" filter_domain="[ | |||
| '|', '|', '|', | |||
| ('name', 'ilike', self), ('ref', 'ilike', self), ('account_id', 'ilike', self), ('partner_id', 'ilike', self)]"/> | |||
| <field name="debit" string="Amount" filter_domain="[ | |||
| '|', '|', ('debit', 'ilike', self), ('credit', 'ilike', self), ('balance', 'ilike', self)]"/> | |||
There was a problem hiding this comment.
In fact no need to check the balance since the balance is just the sign version of the debit and credit, so
Suggested change
| '|', '|', ('debit', 'ilike', self), ('credit', 'ilike', self), ('balance', 'ilike', self)]"/> | |
| ['|', ('debit', 'ilike', self), ('credit', 'ilike', self)]"/> |
mograby3500
force-pushed
the
18.0-rd-accounting-onboarding-allow-search-on-amount-in-move-line-alah
branch
2 times, most recently
from
1ca3ee3 to
597eef0
Compare
malb-odoo
reviewed
Jul 3, 2025
| @@ -305,6 +305,8 @@ | |||
| <field name="name" string="Journal Item" filter_domain="[ | |||
| '|', '|', '|', | |||
| ('name', 'ilike', self), ('ref', 'ilike', self), ('account_id', 'ilike', self), ('partner_id', 'ilike', self)]"/> | |||
| <field name="debit" string="Amount" filter_domain="[ | |||
| '|', ('debit', 'ilike', self), ('credit', 'ilike', self)]"/> | |||
There was a problem hiding this comment.
In one line and it would be perfect but will not block for that it's not the point of the onboarding 😄
This commit aims to add the ability for users to search on records with (debit, credit or balance) that matches the search keyword. task-4908897
mograby3500
force-pushed
the
18.0-rd-accounting-onboarding-allow-search-on-amount-in-move-line-alah
branch
from
597eef0 to
6d35198
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit aims to add the ability for users
to search on records with (debit, credit or balance) that matches the search keyword.
Task-4908897