[IMP] website: show welcome message on homepage #4609
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
divy-odoo
force-pushed
the
master-mysterious-egg-tour-divy-3
branch
from
cd9d892 to
e66d5d3
Compare
| while (wrapEl.firstChild) { | ||
| wrapEl.removeChild(wrapEl.lastChild); | ||
| } | ||
| wrapEl.append(this.welcomeMessageEl); |
There was a problem hiding this comment.
wrapEl.replaceChildren(this.welcomeMessageEl);
| @@ -21,4 +21,10 @@ | |||
| </div> | |||
| </t> | |||
|
|
|||
| <t t-name="website.homepage_editor_welcome_message"> | |||
| <div class="container text-center pt128 pb128 h-100"> | |||
There was a problem hiding this comment.
The font family is off. In the old editor there was a class .o_homepage_editor_welcome_message on this div, which applied:
.o_homepage_editor_welcome_message {
padding-top: 128px;
padding-bottom: 128px;
font-family: $o-font-family-sans-serif;
}We can use the bootstrap classes for the padding, but let's keep the font :)
There was a problem hiding this comment.
Hello @robinlej , thanks for the review. 😄
Nice catch! I've made the changes, but here I'm not sure if this is the right bundle/folder for front-end SCSS (as I didn’t see any major front-end scss file in this module). Hopefully, it’s correct, but could you please double-check it? Let me know if any change there.
Thanks in advance 🙂
There was a problem hiding this comment.
Oops, I didn't see your comment before merging. Now that you ask, I wonder if it shouldn't be in web.assets_backend instead (backend being when you're connected).
There was a problem hiding this comment.
I thought that but No, assets_backend won't work here. This style needs to be loaded inside the iframe containing the website preview, whereas assets_backend is loaded in the web client, where the website selector isn't accessible.
divy-odoo
force-pushed
the
master-mysterious-egg-tour-divy-3
branch
2 times, most recently
from
3c6da1b to
84fda32
Compare
divy-odoo
force-pushed
the
master-mysterious-egg-tour-divy-3
branch
from
84fda32 to
0e638d2
Compare
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
No description provided.