[FIX] html_builder: error message for invalid URL

[emge-odoo]

[LEBL] Select a text, add a link, add "http://", save, click on the link, traceback occurs
https://pad.odoo.com/p/mysterious-egg-builder-editor-bug

[robodoo]

This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged.

[Jinjiu96]

Hello 👋 I had a small discussion with @robinlej yesterday before I left, so a better way to fix it would be at deduceUrl or applyDeducedUrl in link_popover.js. When we have url as http://or https:// it's better to consider it as an empty input. When we have an empty url and click apply, we don't create a link. By doing this, we avoid to have a link element with an invalid URL which causes this traceback 🙏

[emge-odoo]

Hello 👋 I had a small discussion with @robinlej yesterday before I left, so a better way to fix it would be at deduceUrl or applyDeducedUrl in link_popover.js. When we have url as http://or https:// it's better to consider it as an empty input. When we have an empty url and click apply, we don't create a link. By doing this, we avoid to have a link element with an invalid URL which causes this traceback 🙏

Hello, I made a change in the fix before I saw your message. I did not do exactly what you asked. If the URL is not valid I simply don't call the onApply function. The advantage of doing this is that it works for any invalid url not only "https://" and "http://". One drawback might be that now, the onApply call is done after loadAsyncLinkPreview has finished. If this is an issue, I can modify the code by splitting loadAsyncLinkPreview in two to avoid waiting on an asynchronous function before calling onApply. Let me know what you think.

[emge-odoo]

I also don"t really know if there are cases in which we want to call the onApply function even if the URL is invalid

[Jinjiu96]

Here is my feedback, hope it helps 🙏

[Jinjiu96]

Looks good to me, just remember the translation remark from Robin and then we are good to go 😉