Do not start all plugins in translate mode #4598
Merged
+227
−120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
loco-odoo
force-pushed
the
master-mysterious-egg-loco-1
branch
3 times, most recently
from
ad51670 to
cf167fd
Compare
FrancoisGe
reviewed
May 8, 2025
| @@ -99,10 +99,10 @@ export class VisibilityPlugin extends Plugin { | |||
| const isShown = this.toggleVisibilityStatus(editingEl, show); | |||
|
|
|||
| if (!isShown) { | |||
| this.dependencies["builder-options"].deactivateContainers(); | |||
| this.dispatchTo("deactivate_containers"); | |||
There was a problem hiding this comment.
this.dispatchTo("element_toggle_visibility_handlers", { el, isShown });
| if (show) { | ||
| this.shared["builder-options"].updateContainers(snippetEl); | ||
| this.getResource("update_containers").forEach((handler) => handler(snippetEl)); |
loco-odoo
force-pushed
the
master-mysterious-egg-loco-1
branch
7 times, most recently
from
b2fa8de to
12f6a12
Compare
FrancoisGe
reviewed
May 13, 2025
Comment on lines
111
to
118
| deactivateContainersIfTargetHidden(elToVisibilityMap) { | ||
| for (const [el, visibility] of elToVisibilityMap.entries()) { | ||
| if (el.contains(this.target) && !visibility) { | ||
| this.deactivateContainers(); | ||
| return; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
We need something more generic. Why not use onSelectedElVisibilityUpdated ?
Maybe rename onElVisibilityUpdated.
Check if el.contains(this.target) || el === this.target && !show then this.deactivateContainers
loco-odoo
force-pushed
the
master-mysterious-egg-loco-1
branch
from
12f6a12 to
821df91
Compare
loco-odoo
force-pushed
the
master-mysterious-egg-loco-1
branch
from
821df91 to
7527a6b
Compare
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.