Delete dead code + use website admin navbar #4578
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
robinlej
force-pushed
the
master-mysterious-egg-role-1
branch
11 times, most recently
from
87803fd to
8a2c7d7
Compare
robinlej
force-pushed
the
master-mysterious-egg-role-1
branch
from
8a2c7d7 to
daee4b0
Compare
robinlej
changed the title
FrancoisGe
force-pushed
the
master-mysterious-egg
branch
from
5b240d1 to
558b8e7
Compare
robinlej
force-pushed
the
master-mysterious-egg-role-1
branch
from
daee4b0 to
c924434
Compare
robinlej
commented
May 20, 2025
| @@ -31,7 +31,7 @@ export class WebsiteSystrayItem extends Component { | |||
| } | |||
|
|
|||
| get hasMultiWebsites() { | |||
| return this.website.hasMultiWebsites; | |||
| return this.website.websites.length > 1; | |||
There was a problem hiding this comment.
For this specific line, see odoo@4ec38b3
robinlej
force-pushed
the
master-mysterious-egg-role-1
branch
2 times, most recently
from
9f62cc5 to
ac1890d
Compare
ged-odoo
force-pushed
the
master-mysterious-egg
branch
from
ea446c5 to
f76e670
Compare
robinlej
force-pushed
the
master-mysterious-egg-role-1
branch
from
ac1890d to
2370ba8
Compare
ged-odoo
force-pushed
the
master-mysterious-egg
branch
from
f76e670 to
4c8c066
Compare
robinlej
changed the base branch from
master-mysterious-egg
to
master-mysterious-egg-next
robinlej
force-pushed
the
master-mysterious-egg-role-1
branch
2 times, most recently
from
1bfea71 to
58d45cc
Compare
This commit introduces a full rewrite of the website builder to leverage the OWL framework and the new HTML editor. The goal is to modernize the codebase, improve maintainability, and provide a more reactive and modular architecture. A major part of this refactoring is the complete rethinking of how options are defined. They are now implemented as OWL components or simple template-driven views, and registered as plugins. The system introduces two distinct concepts: *options*, which handle the user interface, and *actions*, which encapsulate the actual DOM or HTML updates. The builder code is now split into two addons: - `html_builder`: contains a shared foundation for building HTML UIs, designed to be reusable across apps, including mass mailing. - `website`: contains all website-specific logic and components. The legacy builder code has not been removed yet, as parts of it are still in use, most notably in the mass mailing application. It will be removed in the near future. Many thanks to everyone who contributed to this project, whether through code, testing, reviews, design, or support — your efforts made this major milestone possible. Also, this sentence was totally not generated by a AI language model. Co-authored-by: aans-odoo <[email protected]> Co-authored-by: Alessandro Lupo <[email protected]> Co-authored-by: Alice Gaudon <[email protected]> Co-authored-by: Antoine Guenet <[email protected]> Co-authored-by: Augustin (duau) <[email protected]> Co-authored-by: Benoit Socias <[email protected]> Co-authored-by: chdh-odoo <[email protected]> Co-authored-by: Davide Bonetto <[email protected]> Co-authored-by: Denis Rygaert <[email protected]> Co-authored-by: divy-odoo <[email protected]> Co-authored-by: emge-odoo <[email protected]> Co-authored-by: fdardenne <[email protected]> Co-authored-by: FrancoisGe <[email protected]> Co-authored-by: Géry Debongnie <[email protected]> Co-authored-by: Guillaume Jacquet <[email protected]> Co-authored-by: Jinjiu Liu <[email protected]> Co-authored-by: ksbh-odoo <[email protected]> Co-authored-by: Louis (loco) <[email protected]> Co-authored-by: Mohammed Shekha <[email protected]> Co-authored-by: Nicolas Bayet <[email protected]> Co-authored-by: panv-odoo <[email protected]> Co-authored-by: paru-odoo <[email protected]> Co-authored-by: Rahil Ghanchi <[email protected]> Co-authored-by: Robin Lejeune (role) <[email protected]> Co-authored-by: Rodolpho Lima <[email protected]> Co-authored-by: Sanjay Sharma <[email protected]> Co-authored-by: Sébastien Blondiau <[email protected]> Co-authored-by: Sébastien Geelen <[email protected]> Co-authored-by: Serhii Rubanskyi - seru <[email protected]> Co-authored-by: Soukéina Bojabza <[email protected]> Co-authored-by: Subhadeep <[email protected]> Co-authored-by: visp-odoo <[email protected]>
ged-odoo
force-pushed
the
master-mysterious-egg-next
branch
from
6e36b56 to
48edd7d
Compare
robinlej
force-pushed
the
master-mysterious-egg-role-1
branch
from
58d45cc to
dfdfc13
Compare
Because when we change the link element in the popover and apply, we always close the current one and open a new one, the loading at the apply is redundant. We do the reopening to let the overlay plugin reposition popover, and let browser handle the relative/root-relative url to add the domain.
Logo can have two views: image and a text one, and so we pass the view of the one that's displayed right now. Or, if the logo is hidden, we pass the image logo.
robinlej
force-pushed
the
master-mysterious-egg-role-1
branch
from
9610278 to
f39c03f
Compare
ged-odoo
force-pushed
the
master-mysterious-egg-next
branch
7 times, most recently
from
7b6e21e to
921bf70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.