Skip to content

Potential fixes for 4 code scanning alerts #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Potential fixes for 4 code scanning alerts #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf954ba
Potential fix for code scanning alert no. 24: Database query built fr…
austenstone Sep 24, 2025
6d3c70e
Potential fix for code scanning alert no. 23: Database query built fr…
austenstone Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions model/auth.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ var config = require("../config"),
function do_auth(username, password) {
var db = pgp(config.db.connectionString);

var q = "SELECT * FROM users WHERE name = '" + username + "' AND password ='" + password + "';";
var q = "SELECT * FROM users WHERE name = $1 AND password = $2;";

return db.one(q);
return db.one(q, [username, password]);
}

module.exports = do_auth;
26 changes: 8 additions & 18 deletions model/products.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,41 +11,31 @@ function list_products() {

function getProduct(product_id) {

var q = "SELECT * FROM products WHERE id = '" + product_id + "';";
var q = "SELECT * FROM products WHERE id = $1;";

return db.one(q);
return db.one(q, [product_id]);
}

function search(query) {

var q = "SELECT * FROM products WHERE name ILIKE '%" + query + "%' OR description ILIKE '%" + query + "%';";
var q = "SELECT * FROM products WHERE name ILIKE $1 OR description ILIKE $1;";

return db.many(q);
return db.many(q, ['%' + query + '%']);

}

function purchase(cart) {

var q = "INSERT INTO purchases(mail, product_name, user_name, product_id, address, phone, ship_date, price) VALUES('" +
cart.mail + "', '" +
cart.product_name + "', '" +
cart.username + "', '" +
cart.product_id + "', '" +
cart.address + "', '" +
cart.ship_date + "', '" +
cart.phone + "', '" +
cart.price +
"');";

return db.one(q);
var q = "INSERT INTO purchases(mail, product_name, user_name, product_id, address, phone, ship_date, price) VALUES($1, $2, $3, $4, $5, $6, $7, $8);";

return db.one(q, [cart.mail, cart.product_name, cart.username, cart.product_id, cart.address, cart.phone, cart.ship_date, cart.price]);
}

function get_purcharsed(username) {

var q = "SELECT * FROM purchases WHERE user_name = '" + username + "';";
var q = "SELECT * FROM purchases WHERE user_name = $1;";

return db.many(q);
return db.many(q, [username]);

}

Expand Down
Loading