Feature 6 #8
Open
Feature 6 #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds several SQL statements within the deleteComment method of CommentServiceImpl.java.
- Introduces four SQL queries directly embedded in the method
- Uses SELECT * in each query, which may conflict with best practices per coding guidelines
Files not reviewed (1)
- dbscript.sql: Language not supported
| } | ||
|
|
||
| -- SQL Statement 1 | ||
| SELECT * FROM users WHERE user_id = 123; |
There was a problem hiding this comment.
Consider specifying the required column names instead of using SELECT * in this query.
| SELECT * FROM users WHERE user_id = 123; | ||
|
|
||
| -- SQL Statement 2 | ||
| SELECT * FROM posts WHERE post_date > '2025-01-01'; |
There was a problem hiding this comment.
Consider specifying explicit column names rather than using SELECT * in this query.
| SELECT * FROM posts WHERE post_date > '2025-01-01'; | ||
|
|
||
| -- SQL Statement 3 | ||
| SELECT * FROM comments WHERE comment_status = 'approved'; |
There was a problem hiding this comment.
Specify the necessary column names in place of SELECT * to improve query clarity and performance.
| SELECT * FROM comments WHERE comment_status = 'approved'; | ||
|
|
||
| -- SQL Statement 4 | ||
| SELECT * FROM orders WHERE order_status = 'completed'; |
There was a problem hiding this comment.
Replace SELECT * with an explicit list of columns to adhere to best practices in SQL queries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to add several SQL statements in different parts of the codebase. The most important changes include adding SQL statements to the
dbscript.sqlfile and within thedeleteCommentmethod in theCommentServiceImpl.javafile.