feat: add access rights check before job configuration#286
Open
ndrpp wants to merge 5 commits intofeat/redesignfrom
Open
feat: add access rights check before job configuration#286ndrpp wants to merge 5 commits intofeat/redesignfrom
ndrpp wants to merge 5 commits intofeat/redesignfrom
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ndrpp
requested review from
alexcos20,
andreip136,
bogdanfazakas,
denisiuriet,
giurgiur99 and
mihaisc
as code owners
Contributor
|
If You can take a look at compute1 |
Member
Author
oh, ok. I thought we were going for the wildcard '*' to allow all |
giurgiur99
reviewed
Feb 11, 2026
src/utils/check-env-access.ts
Outdated
| if (!walletAddress) return null; | ||
| if (!access?.addresses) return true; | ||
| if (access.addresses.length === 0) return true; | ||
| if (access.addresses.some((a) => a === '*')) return true; |
Contributor
There was a problem hiding this comment.
There is no wildcard (*) used. Should also check access lists for access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Changes proposed in this PR:
access.addressesarray