opam upgrade: Do not show the not-up-to-date message with packages tagged with avoid-version #6273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
force-pushed
the
no-avoid-version-upgrade
branch
from
7da8317 to
f810b2a
Compare
rjbou
reviewed
Oct 29, 2024
| let name = OpamPackage.name pkg in | ||
| let pkgs = OpamPackage.packages_of_name t.packages name in | ||
| let latest = | ||
| OpamPackage.Set.fold (fun pkg latest -> |
There was a problem hiding this comment.
this variable named pkg and the one defined 4 lines above are not the "same package" but have the same name, this can be misleading when reading the code.
There was a problem hiding this comment.
I disagree. Since the name above doesn't have any use below i think it's better to shadow it. The same pattern is used in different places in our code already and i think it make sense to use it here
| (OpamPackage.names_of_packages to_check) | ||
| OpamPackage.Set.fold (fun pkg acc -> | ||
| let name = OpamPackage.name pkg in | ||
| let pkgs = OpamPackage.packages_of_name t.packages name in |
There was a problem hiding this comment.
I don't know if it worth working on the set of version instead of package one.
There was a problem hiding this comment.
it simplifies the code greatly. Otherwise we would need to have an intermediate map of set and update it
…d with avoid-version/deprecated
kit-ty-kate
force-pushed
the
no-avoid-version-upgrade
branch
from
f810b2a to
9aa898b
Compare
…gged with avoid-version
kit-ty-kate
force-pushed
the
no-avoid-version-upgrade
branch
from
9aa898b to
3c9bdb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6271