add Eio_unix.Sockopt for setting/getting socket options #575
Conversation
There was a problem hiding this comment.
Seems like socket options could be useful on non-Unix systems too. We could define the type in Eio.Net as an extensible variant and put the common ones there, adding Unix specific ones in Eio_unix.Net, etc. Would have to decide what to do about unsupported options.
SGTM. Right now, if a given sockopt isn't defined, it becomes (-1) and a call to it raises EINVAL (similar behaviour to the OCaml Unix module). I'll move the common definitions that work on Windows as well to Eio.Net, and then put the remaining ones in Eio_unix. |
avsm
force-pushed
the
sockopt
branch
2 times, most recently
from
52c2ac8 to
65fa53b
Compare
|
In #322, @create2000 is asking about helping to finish this. Are we happy with the current design? What needs to happen beyond rebasing it? It looks to me like some of the options (those not specific to Unix) should move to Possibly Might need a way to pass a list of options when connecting or binding (since we do that in one step, and maybe it's too late to set some options by then?). Might want some fancy heterogeneous list to hold them, since they have various types. @create2000 I don't know if it's a good first issue or not. It uses some fancy types and involves C code. On the other hand, it's mostly done! |
|
Re:design -- my impression is that we should definitely move parts to Perhaps a follow up PR can work to support options being set at the point of connecting/binding (as you mentioned, this seems very related to #713)? |
|
I've pushed a rebase with all the suggestions here. There are loads of Linux and Windows specific ones to add, but I wanted to check if this is version is heading in the right direction first @talex5 @patricoferris |
| type _ t = .. | ||
|
|
||
| type _ t += | ||
| | SO_DEBUG : bool t (** Enable socket debugging *) |
There was a problem hiding this comment.
Perhaps SO should be a sub-module?
There was a problem hiding this comment.
Do you mean separate the socket options fro the TCP/IP level options? Seems easier to just keep the types corresponding to the names of the sockopts themselves as they're well known.
|
I've added a bunch of Linux specific calls now (skipping multicast for now, and some of the more exotic fast connect and tcp_info ones), and also dropped SO_ACCEPTCON as it's not portable to macOS with no reasonable alternative (have to do a listen and wait for an EINVAL). It can still be passed directly via the Unix passthrough, but it's not much use in Eio where you know the state of your sockets anyway. |
|
Tests should be fixed now as I've pushed a fix to ignore ENOPROTOOPT errors for IP_LOCAL IP sockopts that only work on Linux >6.3 |
This adds a Eio.Net.Sockopt.t extensible variant where portable options are exposed, and backend-specific sockopts for Unix and Linux. Windows can be added later, but is not part of this commit. Reviewed-by: Thomas Leonard <[email protected]>
|
Squashed commits, should be ready for merge. |
There are some socket options that are Linux-specific which are quite handy to have. This adds a Eio_unix.Sockopt module which works on Eio_unix.Fd.t values.
This is a draft PR to check on the interface: the current PR replaces the need for Unix.setsockopt and has a single simple GADT for the socket options. Alternatively we could just expose the extended ones in the same style as upstream OCaml as a separate set of types, too. Opinions welcome.