Skip to content

Skip tailcall argument check for OCaml functions #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 15, 2025
Merged

Skip tailcall argument check for OCaml functions #15

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6d9870b
Skip tailcall argument check for OCaml functions
usuyus Aug 8, 2025
300f470
Move the ocamlcc check to a more reasonable location
usuyus Aug 15, 2025
839b134
Add comment back...
usuyus Aug 15, 2025
22ca8d4
CCName
usuyus Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions llvm/lib/IR/Verifier.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3580,7 +3580,8 @@ void Verifier::verifyMustTailCall(CallInst &CI) {
AttributeList CallerAttrs = F->getAttributes();
AttributeList CalleeAttrs = CI.getAttributes();
if (CI.getCallingConv() == CallingConv::SwiftTail ||
CI.getCallingConv() == CallingConv::Tail) {
CI.getCallingConv() == CallingConv::Tail ||
CI.getCallingConv() == CallingConv::OCaml) {
StringRef CCName =
CI.getCallingConv() == CallingConv::Tail ? "tailcc" : "swifttailcc";

Expand All @@ -3602,9 +3603,6 @@ void Verifier::verifyMustTailCall(CallInst &CI) {
return;
}

// - The caller and callee prototypes must match. Pointer types of
// parameters or return types may differ in pointee type, but not
// address space.
if (!CI.getCalledFunction() || !CI.getCalledFunction()->isIntrinsic()) {
Check(CallerTy->getNumParams() == CalleeTy->getNumParams(),
"cannot guarantee tail call due to mismatched parameter counts", &CI);
Expand Down