"module type of" zap modalities to floor #3922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldfirere
reviewed
Apr 24, 2025
|
@dkalinichenko-js can you look at the updated tests (those with added |
goldfirere
reviewed
Apr 24, 2025
goldfirere
approved these changes
Apr 29, 2025
spiessimon
pushed a commit
to spiessimon/flambda-backend
that referenced
this pull request
Apr 30, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
module type of Mshould zap modalities inMto the strongest. This might cause type error where user usesmodule type of Mto constrain another implementation that's weaker thanM, which is just bad code. I did some quick check in our internal code base and found such bad code to be rare.