-
Notifications
You must be signed in to change notification settings - Fork 25
fix: Allow for 2 buttons in Banner #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @faucomte97)
src/components/page/Banner.tsx
line 10 at r2 (raw file):
import Section from "./Section" export interface BannerProps {
- Need to have 2 type params for the state of each button.
- Call them Button1State and Button3State
- Each type param should have default values
- See the DatePickerFieldProps as an example of how to create a component with type args in the props.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @SKairinos)
src/components/page/Banner.tsx
line 10 at r2 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
- Need to have 2 type params for the state of each button.
- Call them Button1State and Button3State
- Each type param should have default values
- See the DatePickerFieldProps as an example of how to create a component with type args in the props.
Done.
This change is