Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix the Ubuntu version that prevents renaming #138

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

ubifred
Copy link
Contributor

@ubifred ubifred commented Feb 12, 2025

Without this fix the .deb package for ubuntu are not found and does not appear on the release assets

Description

This fixes the missing Ubuntu .deb in release asset, which was dropped because the version of Ubuntu in the renaming step mismatched with Ubuntu deb file naming (22.04 vs 24.04)

Motivation and Context

Because I use this template and the .deb was missing from the release assets

How Has This Been Tested?

I checked that the .deb was in the release assets

Types of changes

CI Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format. -> N/A
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation. -> N/A

@RytoEX RytoEX requested a review from PatTheMav February 12, 2025 18:40
Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your commits.

Without this fix the .deb package for Ubuntu are not found and does not
appear on the release assets.

Co-authored-by: Patrick Heyer <[email protected]>
@RytoEX RytoEX force-pushed the fix-ubuntu-missing-deb branch from 0425869 to dcdb514 Compare March 4, 2025 19:47
@RytoEX RytoEX changed the title CI: Fix the ubuntu version that prevents renaming CI: Fix the Ubuntu version that prevents renaming Mar 4, 2025
@RytoEX RytoEX merged commit de669bb into obsproject:master Mar 4, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants