Skip to content

Error on invalid dispose function. #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 17, 2020
Merged

Error on invalid dispose function. #162

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
701c4c7
Warn on invalid disposal function.
mbostock Mar 15, 2020
cab14c4
On second thought, throw.
mbostock Mar 15, 2020
dad063a
Better error message.
mbostock Mar 17, 2020
e0baa30
Better error message.
mbostock Mar 17, 2020
b833ab0
Better error message.
mbostock Mar 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/generators/observe.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ export default function(initialize) {
let resolve;
const dispose = initialize(change);

if (dispose != null && typeof dispose !== "function") {
throw new Error("invalid dispose");
}

function change(x) {
if (resolve) resolve(x), resolve = null;
else stale = true;
Expand Down
4 changes: 4 additions & 0 deletions src/generators/queue.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ export default function(initialize) {
const queue = [];
const dispose = initialize(push);

if (dispose != null && typeof dispose !== "function") {
throw new Error("invalid dispose");
}

function push(x) {
queue.push(x);
if (resolve) resolve(queue.shift()), resolve = null;
Expand Down