Skip to content

Commit cab14c4

Browse files
committed
On second thought, throw.
1 parent 701c4c7 commit cab14c4

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

src/generators/observe.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,10 @@ export default function(initialize) {
44
let stale = false;
55
let value;
66
let resolve;
7-
let dispose = initialize(change);
7+
const dispose = initialize(change);
88

99
if (dispose != null && typeof dispose !== "function") {
10-
console.warn("dispose is not a function; ignoring", dispose);
11-
dispose = null;
10+
throw new Error("invalid dispose");
1211
}
1312

1413
function change(x) {

src/generators/queue.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
import that from "../that.js";
22

33
export default function(initialize) {
4-
const queue = [];
54
let resolve;
6-
let dispose = initialize(push);
5+
const queue = [];
6+
const dispose = initialize(push);
77

88
if (dispose != null && typeof dispose !== "function") {
9-
console.warn("dispose is not a function; ignoring", dispose);
10-
dispose = null;
9+
throw new Error("invalid dispose");
1110
}
1211

1312
function push(x) {

0 commit comments

Comments
 (0)