Skip to content

Commit 701c4c7

Browse files
committed
Warn on invalid disposal function.
1 parent 7d3949c commit 701c4c7

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

src/generators/observe.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,12 @@ export default function(initialize) {
44
let stale = false;
55
let value;
66
let resolve;
7-
const dispose = initialize(change);
7+
let dispose = initialize(change);
8+
9+
if (dispose != null && typeof dispose !== "function") {
10+
console.warn("dispose is not a function; ignoring", dispose);
11+
dispose = null;
12+
}
813

914
function change(x) {
1015
if (resolve) resolve(x), resolve = null;

src/generators/queue.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,14 @@
11
import that from "../that.js";
22

33
export default function(initialize) {
4-
let resolve;
54
const queue = [];
6-
const dispose = initialize(push);
5+
let resolve;
6+
let dispose = initialize(push);
7+
8+
if (dispose != null && typeof dispose !== "function") {
9+
console.warn("dispose is not a function; ignoring", dispose);
10+
dispose = null;
11+
}
712

813
function push(x) {
914
queue.push(x);

0 commit comments

Comments
 (0)