Skip to content

Data-connector and Database-proxy reconciliations #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Data-connector and Database-proxy reconciliations #72

wants to merge 31 commits into from

Conversation

Sylvestre67
Copy link

@Sylvestre67 Sylvestre67 commented Jan 26, 2023 •
edited
Loading

Resolves https://github.com/observablehq/projects/issues/421
https://github.com/observablehq/projects/issues/423 https://github.com/observablehq/projects/issues/422

  • Add SNOWFLAKE_TEST_CREDENTIALS as secret on GitHub Actions for the test to pass.

See related pr on data-connector: https://github.com/observablehq/observablehq/pull/10168

Includes #68.

  • Setup test GH actions workflows.
  • Migrate general pooling from data-connector to database-proxy.
  • Migrate MySQL tests from the data-connector, and refactor to use mocha
  • Cleaned up SQL Server tests.
  • Migrate Postgres client method from the data-connector
  • Migrate Postgres tests from the data-connector, and refactor to use mocha
  • Migrate Snowflake client method from the data-connector
  • Migrate Snowflake tests from the data-connector, and refactor to use mocha
  • Add linter and fix format inconsistencies

@Sylvestre67 Sylvestre67 mentioned this pull request Feb 1, 2023
Closed
@Sylvestre67 Sylvestre67 changed the title Pools migrations Data-connector and Database-proxy reconciliations Feb 1, 2023
@Sylvestre67 Sylvestre67 marked this pull request as ready for review February 1, 2023 17:57
@Sylvestre67 Sylvestre67 requested a review from visnup February 2, 2023 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visnup visnup Awaiting requested review from visnup

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sylvestre67 @wiltsecarpenter