enhance: be smarter about timeouts when waiting for deployments #4530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Pausing my work on this to pick up something higher priority. I think this will work; I just haven't actually tested it in k8s yet. |
g-linville
force-pushed
the
smart-pod-timeout
branch
from
2b3169d to
fea36e9
Compare
Signed-off-by: Grant Linville <[email protected]>
Signed-off-by: Grant Linville <[email protected]>
g-linville
force-pushed
the
smart-pod-timeout
branch
from
fea36e9 to
89080b8
Compare
Member
Author
|
Tested, this works as expected!a |
thedadams
reviewed
Oct 14, 2025
Signed-off-by: Grant Linville <[email protected]>
thedadams
reviewed
Oct 15, 2025
Signed-off-by: Grant Linville <[email protected]>
Signed-off-by: Grant Linville <[email protected]>
thedadams
approved these changes
Oct 16, 2025
njhale
approved these changes
Oct 22, 2025
pkg/mcp/kubernetes.go
Outdated
| if err != nil { | ||
| return "", ErrHealthCheckTimeout | ||
| // analyzePodStatus examines a pod's status to determine if we should retry waiting for it | ||
| // or if we should fail immediately. Returns (shouldRetry, reason). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #4261