Add useNativeDriver as a configuration option
#142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using this library the latest version of React Native (0.63.4) raises warnings about explicitly setting `useNativeDriver` for the `Animated` functions. I considered hardcoding the value as false for instances of `Animated.event` and `Animated.spring` to maintain the existing behaviour but felt like exposing it as an option adds very little extra complexity to the library while ensuring people can opt in to the native animations if they want.
|
Please merge this to get rid of annoying warning |
|
There is another such annoying warning, that I fixed on the latest PR, please check on that too : ) . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using this library the latest version of React Native (0.63.4) raises
warnings about explicitly setting
useNativeDriverfor theAnimatedfunctions.
I considered hardcoding the value as false for instances of
Animated.eventandAnimated.springto maintain the existingbehaviour but felt like exposing it as an option adds very little extra
complexity to the library while ensuring people can opt in to the native
animations if they want.