Conversation
Deployed to Cloudflare Pages
|
|
Testing requirements:
Current flow only works with existing templates, not with custom build, as custom build needs additional validation, so it does not override the ERC-8004 secrets. |
@lubej, @matevz, I think that for the hackathoners the Custom App/Build template would be the one that will be used. And @buberdds just enabled the Custom App/Build to also work with Testnet in #362. @buberdds, can you help @lubej with enabling ERC-8004 support for Custom App/Build? |
Right, so ERC-8004 support for Custom App/Build shouldn't be hard to implement, just needs some validation for secrets, and the step should be the same as in template flow. Will add this tomorrow. I just went with the template flow first, as it was easier to test. |
eaa3b6a to
d095658
Compare
|
I would request the full RPC url instead of making it dependent on infura. |
Right, as for the RPC url and validator address, I would rather have a dropdown with available networks, and you could change them potentially via secrets if you wanted to. And if you want some custom implementation, you can do it via CLI anyway. I wouldn't want the complexity of free form on ROFL App - as the intention is for less advanced users - and they may wonder why is not working as intended. This is just for the initial implementation, I think we can fine tune it later. |
ab6d92f to
3659698
Compare
matevz
left a comment
There was a problem hiding this comment.
I couldn't find the ROFL manifest snippet in this PR, but the new support for retaining the ERC-8004 agent ID when you restart ROFL requires another volume to be mounted. Please check out https://github.com/oasisprotocol/erc-8004?tab=readme-ov-file#rofl-8004-startup-image and update the template accordingly.
59bbcfc to
96057ef
Compare
matevz
left a comment
There was a problem hiding this comment.
I checked out the flow and works as expected. Left some suggestions.
- change prefix to ERC8004
- add validation for ERC-8004 reserved fields
- Remove custom build skip for ERC8004Step
- pin rofl-8004 image
- update signing key placeholder to reflect the validation
- enable rest of the optional configuration keys
- Make signing key optional
- Add MCP,A2A,ENS fields
- according to https://github.com/oasisprotocol/erc-8004 README
- ERC-8004 checkbox unchecked by default, hide/show - Sepolia selected by default - Change info box for private key
This PR integrates https://github.com/oasisprotocol/erc-8004, by including rofl-8004 service inside compose.yaml. Provides another step, that can be skipped in create flow. Shows the ERC-8004 "token"/NFT in AppDetails.
Part of #359