Skip to content

Add initial ERC-8004 support#361

Open
lubej wants to merge 34 commits intomasterfrom
ml/erc-8004
Open

Add initial ERC-8004 support#361
lubej wants to merge 34 commits intomasterfrom
ml/erc-8004

Conversation

@lubej
Copy link
Contributor

@lubej lubej commented Nov 20, 2025

This PR integrates https://github.com/oasisprotocol/erc-8004, by including rofl-8004 service inside compose.yaml. Provides another step, that can be skipped in create flow. Shows the ERC-8004 "token"/NFT in AppDetails.

Part of #359

@github-actions
Copy link

github-actions bot commented Nov 20, 2025

Deployed to Cloudflare Pages

Latest commit: 597eaf1c1d01bd553dfe34ceec4f67ff5b4496b3
Status:✅ Deploy successful!
Preview URL: https://015ea6e0.rofl-app.pages.dev
Alias: https://pr-361.rofl-app.pages.dev

@lubej
Copy link
Contributor Author

lubej commented Nov 20, 2025

Testing requirements:

  • Pinata JWT token
  • Infura API KEY
  • Sepolia testnet account with some SepoliaETH, which will pay for Agenty Identity registration

Current flow only works with existing templates, not with custom build, as custom build needs additional validation, so it does not override the ERC-8004 secrets.

@lubej lubej requested review from buberdds, csillag, lukaw3d and matevz and removed request for buberdds November 20, 2025 15:04
@tjanez
Copy link
Contributor

tjanez commented Nov 20, 2025

Current flow only works with existing templates, not with custom build, as custom build needs additional validation, so it does not override the ERC-8004 secrets.

@lubej, @matevz, I think that for the hackathoners the Custom App/Build template would be the one that will be used.

And @buberdds just enabled the Custom App/Build to also work with Testnet in #362.

@buberdds, can you help @lubej with enabling ERC-8004 support for Custom App/Build?

@lubej
Copy link
Contributor Author

lubej commented Nov 20, 2025

Current flow only works with existing templates, not with custom build, as custom build needs additional validation, so it does not override the ERC-8004 secrets.

@lubej, @matevz, I think that for the hackathoners the Custom App/Build template would be the one that will be used.

And @buberdds just enabled the Custom App/Build to also work with Testnet in #362.

@buberdds, can you help @lubej with enabling ERC-8004 support for Custom App/Build?

Right, so ERC-8004 support for Custom App/Build shouldn't be hard to implement, just needs some validation for secrets, and the step should be the same as in template flow. Will add this tomorrow. I just went with the template flow first, as it was easier to test.

@lubej lubej force-pushed the ml/erc-8004 branch 4 times, most recently from eaa3b6a to d095658 Compare November 21, 2025 13:53
@rube-de
Copy link

rube-de commented Nov 21, 2025

I would request the full RPC url instead of making it dependent on infura.
The validator agent address would be also helpful in the form.

@lubej
Copy link
Contributor Author

lubej commented Nov 21, 2025

I would request the full RPC url instead of making it dependent on infura. The validator agent address would be also helpful in the form.

Right, as for the RPC url and validator address, I would rather have a dropdown with available networks, and you could change them potentially via secrets if you wanted to. And if you want some custom implementation, you can do it via CLI anyway. I wouldn't want the complexity of free form on ROFL App - as the intention is for less advanced users - and they may wonder why is not working as intended. This is just for the initial implementation, I think we can fine tune it later.

@lubej lubej force-pushed the ml/erc-8004 branch 2 times, most recently from ab6d92f to 3659698 Compare December 2, 2025 15:55
Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find the ROFL manifest snippet in this PR, but the new support for retaining the ERC-8004 agent ID when you restart ROFL requires another volume to be mounted. Please check out https://github.com/oasisprotocol/erc-8004?tab=readme-ov-file#rofl-8004-startup-image and update the template accordingly.

@lubej lubej force-pushed the ml/erc-8004 branch 2 times, most recently from 59bbcfc to 96057ef Compare January 12, 2026 12:12
@lubej lubej requested a review from matevz January 12, 2026 13:33
Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked out the flow and works as expected. Left some suggestions.

lubej added 27 commits January 14, 2026 10:22
- change prefix to ERC8004
- add validation for ERC-8004 reserved fields
- Remove custom build skip for ERC8004Step
- update signing key placeholder to reflect the validation
- enable rest of the optional configuration keys
- Make signing key optional
- Add MCP,A2A,ENS fields
- ERC-8004 checkbox unchecked by default, hide/show
- Sepolia selected by default
- Change info box for private key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants