Ensure request body availability after openapi3 filter validation #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks - will try and have a look soon, and then make sure that this is consistent across all middlewares :) |
Check that body exists before copying
|
Just coming back to review this (sorry for the delay!) and I'm going to see if I can spot anything upstream to see if we can fix it in kin-openapi 🤞 (but if not after ~1 hour, I'll get this merged + consistent across middlewares) |
|
This should be resolved upstream in getkin/kin-openapi#1064 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue originally reported in the kin-openapi project (getkin/kin-openapi#743), where the request body was not available to handlers after being processed by the openapi3 filter.
This change:
Existing tests cover this functionality but don't reproduce the issue. It's also not clear why the issue occurs, as
openapi3filter.ValidateRequest()appears to reset the request body.In any case, this approach makes request handling more robust – regardless of how the openapi3 filter or any future updates to it might handle the body.