Skip to content

Docs/Comments: Spelling and grammar fixes across kimchi specs and o1vm lookup #3338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Docs/Comments: Spelling and grammar fixes across kimchi specs and o1vm lookup #3338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c92686
Update lookup_verifier.rs
viktorking7 Sep 23, 2025
cc577cd
Update lookup_prover.rs
viktorking7 Sep 23, 2025
5b5f2e1
Update kimchi.md
viktorking7 Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions book/src/specs/kimchi.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1203,7 +1203,7 @@ One could lay this out as a double-width gate for chained foreign additions and
We reuse the foreign field addition gate for the final bound check since this is an addition with a
specific parameter structure. Checking that the correct right input, overflow, and overflow are used shall
be done by copy constraining these values with a public input value. One could have a specific gate
for just this check requiring less constrains, but the cost of adding one more selector gate outweights
for just this check requiring less constrains, but the cost of adding one more selector gate outweighs
the savings of one row and a few constraints of difference.

##### Integration
Expand Down Expand Up @@ -1696,7 +1696,7 @@ To create the index, follow these steps:
with the table ID of the table.
* Copy the entries from the table to new rows in the corresponding columns of the concatenated table.
* Fill in any unused columns with 0 (to match the dummy value)
6. Pad the end of the concatened table with the dummy value.
6. Pad the end of the concatenated table with the dummy value.
7. Pad the end of the table id vector with 0s.
8. pre-compute polynomial and evaluation form for the look up tables
9. pre-compute polynomial and evaluation form for the table IDs,
Expand Down Expand Up @@ -2119,7 +2119,7 @@ The following sections specify how a prover creates a proof, and how a verifier

To create a proof, the prover expects:

* A prover index, containing a representation of the circuit (and optionaly pre-computed values to be used in the proof creation).
* A prover index, containing a representation of the circuit (and optionally pre-computed values to be used in the proof creation).
* The (filled) registers table, representing parts of the execution trace of the circuit.

```admonish
Expand Down
6 changes: 3 additions & 3 deletions o1vm/src/pickles/lookup_prover.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ where
};

// Compute the 1/beta+sum_i gamma^i value_i for each lookup term
// The inversions is commputed in batch in the end
// The inversions is computed in batch in the end
let mut inverses: Vec<Vec<G::ScalarField>> = wires
.iter()
.zip(arity)
Expand Down Expand Up @@ -101,7 +101,7 @@ where
.interpolate()
};
let columns_poly = columns.my_map(interpolate_col);
// Commiting
// Committing
// TODO avoid cloning
let columns_com = columns_poly
.clone()
Expand All @@ -113,7 +113,7 @@ where
let columns_eval_d8 = columns_poly
.clone()
.my_map(|poly| poly.evaluate_over_domain_by_ref(domain.d8));
// abosrbing commit
// absorbing commit
// TODO don't absorb the wires which already have been
// TODO avoid cloning
columns_com
Expand Down
2 changes: 1 addition & 1 deletion o1vm/src/pickles/lookup_verifier.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ pub fn lookup_verify<
EFqSponge: Clone + FqSponge<G::BaseField, G, G::ScalarField>,
EFrSponge: FrSponge<G::ScalarField>,
>(
// input dependant of main proto
// input dependent of main proto
beta_challenge: G::ScalarField,
gamma_challenge: G::ScalarField,
constraint: ELookup<G::ScalarField>,
Expand Down