[mesa] compat: transaction limit constants update #2647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bleepbloopsify
commented
Nov 18, 2025
Contributor
Author
There was a problem hiding this comment.
Actual changes are in this file
Comment on lines
+63
to
+66
| let { eventElements } = getEvents(accountUpdates); | ||
| const segments = accountUpdates.length; | ||
|
|
||
| let isWithinCostLimit = totalTimeRequired < TransactionCost.COST_LIMIT; | ||
| let isWithinSegmentLimit = segments <= TransactionLimits.MAX_ZKAPP_SEGMENT_PER_TRANSACTION; |
Contributor
Author
There was a problem hiding this comment.
Can I get a double check to make sure this is the right value for segments? Do I need to recurse into the accountUpdates or check their contents?
Trivo25
reviewed
Nov 19, 2025
src/lib/mina/v1/constants.ts
Outdated
| export const MAX_EVENT_ELEMENTS = 100 as const; | ||
| export const MAX_ZKAPP_SEGMENT_PER_TRANSACTION = 16; | ||
| export const MAX_ACTION_ELEMENTS = 1024 as const; | ||
| export const MAX_EVENT_ELEMENTS = 1024 as const; |
Member
There was a problem hiding this comment.
note that this is a different MIP
Contributor
Author
There was a problem hiding this comment.
reverted these changes for scoping reasons
bleepbloopsify
force-pushed
the
leon/3.0/account-update-expansion
branch
from
4c16b05 to
03030b1
Compare
Contributor
Author
|
note: we are on a broken branch, ignore CI for now, we are making incremental upgrades to support |
bleepbloopsify
changed the title
Trivo25
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bringing constants in our mirrored logic up-to-date with mesa: https://github.com/MinaProtocol/mina/pull/17386/files#diff-e9551c7ce072e32a4b8f325f3f2fb913ecd85d80b3dc6905cab71815fb2f4327
Reference PR above, constants changed similarly here.
closes #2636