Update js-sha256 to v0.10.0 #2225
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@zk-invoices-dev can you repeat the reasoning for this PR here on github? It looks like you explained it in the Mina forum, but it would help to include the reasoning in the PR. Also, did you confirm that this branch resolves your issue? It looks like your issue is with mina-signer, but this PR updates o1js. |
Collaborator
|
NVM, I see you laid the issue out in the linked issue, but the point about upgrading mina-signer instead of o1js remains. Maybe we should update the dependency in both packages? But if your issue is with mina-signer, then you should at least upgrade mina-signer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
js-sha256package tov0.10.0References: