Skip to content

Script/download-bindings: prettify script #2198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Script/download-bindings: prettify script #2198

wants to merge 1 commit into from

Conversation

dannywillems
Copy link
Member

  • Uses set -euo pipefail for safer execution.
  • Adds inline comments for clarity.
  • Uses command -v instead of which (preferred for portability).
  • Ensures all variables are properly quoted.
  • Uses ${VAR:-...} idiom for defaulting.

@dannywillems
Script/download-bindings: prettify script
48b36a2 
- Uses set -euo pipefail for safer execution.
- Adds inline comments for clarity.
- Uses command -v instead of which (preferred for portability).
- Ensures all variables are properly quoted.
- Uses ${VAR:-...} idiom for defaulting.
@dannywillems dannywillems requested a review from a team as a code owner May 1, 2025 12:34
@dannywillems dannywillems requested review from Geometer1729 and 45930 May 1, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@querolita querolita querolita approved these changes

@Geometer1729 Geometer1729 Geometer1729 approved these changes

@45930 45930 45930 approved these changes

Assignees
No one assigned
Labels
no changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dannywillems @querolita @Geometer1729 @45930