-
Notifications
You must be signed in to change notification settings - Fork 39
Website: move node management commands into scripts and test in CI #1511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dannywillems
wants to merge
8
commits into
develop
Choose a base branch
from
dw/node-management-doc-in-ci
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
936cfcf
to
fabab65
Compare
d3f2f70
to
e627c47
Compare
6b41778
to
ec095cc
Compare
yamimaio
reviewed
Oct 7, 2025
runs-on: ${{ matrix.os }} | ||
strategy: | ||
matrix: | ||
os: [ubuntu-22.04, ubuntu-24.04] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only ubuntu?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'm struggling adding macOS for the scripts using docker.
Extracted all build-info command examples from the node-management documentation into separate shell scripts that can be tested in CI, following the same pattern used in the developer documentation. Changes: - Created website/docs/node-operators/scripts/ directory - Added build-info-docker.sh for basic Docker usage - Added build-info-docker-version.sh for specific version - Added build-info-native.sh for native binary - Added build-info-native-path.sh for full path usage - Added verify-build-info-docker.sh for Docker verification - Added verify-build-info-native.sh for native verification - Converted node-management.md to .mdx - Updated documentation to use CodeBlock imports with raw-loader
Created a new CI workflow to test the node-operators documentation scripts, ensuring the build-info command examples work correctly across different platforms. The workflow tests: - build-info-docker.sh - Basic Docker build-info command - build-info-docker-version.sh - Version-specific build-info - verify-build-info-docker.sh - Build-info verification with grep Tested on: ubuntu-22.04, ubuntu-24.04, macos-latest Changes: - Added .github/workflows/test-docs-scripts-node-operators.yaml
Move build-info example output and management script examples into separate files that are imported by the documentation. Add CI verification to ensure scripts work correctly and output matches documented examples. Changes: - Move build-info example output to build-info-example.txt - Create check-build-info-format.sh to verify output format - Combine backup scripts into backup-configuration.sh - Create manage-file-permissions.sh (combined from 3 separate scripts) - Create check-system-resources.sh - Create .env file creation scripts (empty, custom, archive variants) - Add test-management-scripts job to CI workflow - Add gh act run command comment to workflow - Update documentation to use CodeBlock imports for all scripts All scripts are tested in CI on ubuntu-22.04, ubuntu-24.04, and macos-latest to ensure they execute correctly.
The VZ (Virtualization.framework) driver was failing to start on GitHub Actions macOS runners with disk mounting errors. Switch to the QEMU driver which is more reliable in CI environments, with explicit resource limits to ensure consistent behavior.
ec095cc
to
450fd7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.