Skip to content

Commit

Permalink
[client-app] Fix SyncbackMetadataTask dependency
Browse files Browse the repository at this point in the history
Summary:
Add a sequentialId check in isDependentOnTask() so that the first
SyncbackMetadataTask won't get blocked on other SyncbackMetadataTasks
in the queue for the same pluginId.

Addresses T8112

Test Plan: Manual

Reviewers: spang, mark, juan

Reviewed By: juan

Differential Revision: https://phab.nylas.com/D4404
  • Loading branch information
Halla Moore committed Apr 11, 2017
1 parent 6159402 commit d226eaf
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ export default class SyncbackMetadataTask extends SyncbackModelTask {
isDependentOnTask(otherTask) {
return (
otherTask instanceof SyncbackMetadataTask &&
otherTask.pluginId === this.pluginId
otherTask.pluginId === this.pluginId &&
otherTask.sequentialId < this.sequentialId
)
}

Expand Down

0 comments on commit d226eaf

Please sign in to comment.