Skip to content

Commit

Permalink
[client-app] only upload 7 characters of the commit hash
Browse files Browse the repository at this point in the history
Summary:
On windows running `git rev-parse --short HEAD` does in fact now give you
9 characters instead of 7 like it does on Mac. This will ensure that
builds get uploaded to the same folder and help ensure we don't post a
version that doesn't exist on the release page.

Test Plan: Manual

Reviewers: juan, halla, spang

Reviewed By: spang

Differential Revision: https://phab.nylas.com/D4217
  • Loading branch information
emorikawa committed Mar 14, 2017
1 parent 30792a4 commit af7d8c9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/client-app/build/tasks/upload-task.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ module.exports = (grunt) => {
if (error) {
return reject();
}
const commitHash = stdout ? stdout.trim() : null;
const commitHash = (stdout ? stdout.trim() : "").slice(0, 7);
packageVersion = json.version;
if (packageVersion.indexOf('-') > 0) {
fullVersion = packageVersion;
Expand Down

0 comments on commit af7d8c9

Please sign in to comment.