Experimental support for pkcs#11 #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use nxp-cst-signer with pkcs11 tokens
|
can we provide also the way we can modify the cfg file once we select pkcs#11? |
kadirc
suggested changes
Jan 30, 2025
src/cst_signer.c
Outdated
| fprintf(fp_csf_file, "\tSource = \"%s/crts/%s\"\n", g_cst_path, rvalue); | ||
|
|
||
| } else { // use PKCS#11 | ||
| DEBUG("PKCS11:\n"); |
There was a problem hiding this comment.
This line results in a syntax error because the VA_ARGS is empty, leading to an extra comma before the closing parenthesis.
I get following error trying to compile this PR:
| In file included from cst_signer.c:9:
| cst_signer.c: In function ‘create_csf_file_v3’:
| ../inc/cst_signer.h:67:107: error: expected expression before ‘)’ token
| 67 | printf("%s:%s:%d: " fmt, __FILE__, __FUNCTION__, __LINE__, __VA_ARGS__); \
| | ^
| cst_signer.c:552:17: note: in expansion of macro ‘DEBUG’
| 552 | DEBUG("PKCS11:\n");
| | ^~~~~
Following change to the macro fixes my problem:
--- a/inc/cst_signer.h
+++ b/inc/cst_signer.h
@@ -64,7 +64,7 @@ const char* desc_opt[] =
#define DEBUG(fmt, ...) do { \
if (1 == g_debug) { \
- printf("%s:%s:%d: " fmt, __FILE__, __FUNCTION__, __LINE__, __VA_ARGS__); \
+ printf("%s:%s:%d: " fmt, __FILE__, __FUNCTION__, __LINE__, ##__VA_ARGS__); \
} \
} while(0)
nxp-cst-signer/inc/cst_signer.h
Line 65 in c632233
There was a problem hiding this comment.
Fixed it, I must have added between testing and comitting (I'm not an expert on git).
Also added some details on how to find the pkcs#11 url, and an example (that must be changed), on PKCS#11 URL in the cfg.
Added some more details on pkcs#11 and csf example file. Fixed a typo in the debug() statement.
Three changes - When adding pkcs#11, accidentially s swapped arguments, causing HAB4 images to not work - nxp-cst signer is sensitive if the cfg have empty "variable=\x0" on last line,as may cause segementation failure - nxp-cst-siger fails invokation of of cst, if the cfg file contains CRLF.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use nxp-cst-signer with cst, and sign images using pkcs11 tokens