Skip to content

Commit

Permalink
Remove "link" feature
Browse files Browse the repository at this point in the history
This is being tracked in issue #1.
  • Loading branch information
nvzqz committed Sep 11, 2020
1 parent 5c439a5 commit a9a0ef2
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 3 deletions.
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,14 @@ The format is based on [Keep a Changelog] and this project adheres to
- **\[breaking\]** Placed each library/framework module behind a feature flag.
- `foundation` transitively enables `objc`.

### Removed

- **\[breaking\]** Removed the `link` cargo feature.

At this point, it's unclear what benefit this feature provides. Further
investigation will be done before this crate is 1.0 to determine if disabling
linking is worthwhile to have. See issue [#1].

## 0.1.0 - 2020-09-10

Initial release.
Expand All @@ -24,4 +32,6 @@ Initial release.
[Keep a Changelog]: http://keepachangelog.com/en/1.0.0/
[Semantic Versioning]: http://semver.org/spec/v2.0.0.html

[#1]: https://github.com/nvzqz/fruity/issues/1

[Unreleased]: https://github.com/nvzqz/fruity/compare/v0.1.0...HEAD
2 changes: 1 addition & 1 deletion src/core_foundation/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@
//! This module corresponds to the **`core_foundation`**
//! [feature flag](../index.html#feature-flags).
#[cfg_attr(feature = "link", link(name = "CoreFoundation", kind = "framework"))]
#[link(name = "CoreFoundation", kind = "framework")]
extern "C" {}
2 changes: 1 addition & 1 deletion src/foundation/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ mod nsstring;
pub use cmp::*;
pub use nsstring::*;

#[cfg_attr(feature = "link", link(name = "Foundation", kind = "framework"))]
#[link(name = "Foundation", kind = "framework")]
extern "C" {}
2 changes: 1 addition & 1 deletion src/objc/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,5 @@ pub use nsobject::*;
pub use obj::*;
pub use sel::*;

#[cfg_attr(feature = "link", link(name = "objc", kind = "dylib"))]
#[link(name = "objc", kind = "dylib")]
extern "C" {}

0 comments on commit a9a0ef2

Please sign in to comment.