fix(#3124): prevent empty icons_right_align response from breaking padding #3125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug is caused in
builder.lua
:In the case of tracked dotfiles,
d:icons_right_align(not d:is(UserDecorator) and node or api_node)
returns{}
from the HiddenDecorator, but insideadd_to_end(t1, t2)
we only checkif not t2
. Not sure if this was intentional, I didn't notice any unexpected behaviour while testing but there may be edge cases I hadn't thought of.