Skip to content

fix(#3124): prevent empty icons_right_align response from breaking padding #3125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rossw01
Copy link

@rossw01 rossw01 commented May 11, 2025

Bug is caused in builder.lua:

for _, d in ipairs(self.decorators) do
  add_to_end(rights, d:icons_right_align(not d:is(UserDecorator) and node or api_node))
end

In the case of tracked dotfiles, d:icons_right_align(not d:is(UserDecorator) and node or api_node) returns {} from the HiddenDecorator, but inside add_to_end(t1, t2) we only check if not t2. Not sure if this was intentional, I didn't notice any unexpected behaviour while testing but there may be edge cases I hadn't thought of.

@rossw01 rossw01 changed the title fix(#3124): prevent empty icons_right response from breaking padding fix(#3124): prevent empty icons_right_align response from breaking padding May 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant