feat: configurable indent marker level

[sand4rt]

closes #1512

[cseickel]

This one is questionable. I don't know for sure, but other code may assume that level 0 means the root node and this could be more than just a visual tweak.

There is also a padding option on the container which may be more appropriate. Either way, see: #1606

[sand4rt]

@pynappo could this be merged? i use this for a while now without issues

[pynappo]

The option should be renamed to something more descriptive like guide_start_level. also, add it to defaults.lua

also in the original issue you mention that you want to use this to add indent guides for levels 0/1. if that's the case, then levels 0/1 should be better handled to have no padding on the left, similar to level 2 and up

0 should have no padding on the left here:

1 should have no padding on the left here (the guide should line up with the folder icon of the root node):

2 looks fine:

[and-rs]

I would like this merged too. Any way in which I could contribute?

[and-rs]

I'd say this is good

[sand4rt]

I would like this merged too. Any way in which I could contribute?

Gladly! Feel free to create a PR against this branch or rebase it and open a new PR, then ill close this one.

I'd say this is good

There are still some issues in there. This is described in: #1570 (comment)

[and-rs]

alrightt of course, there were some issue with the implementation and I also have some questions about how we should handle the end result.

1. Do we really want the indentation marker to start from the node 0? Or is it fine at the node 1? Because I honestly think that node 0 is just not useful at all. I wanted to implement this because if I hid the root node with hide_root_node = true, the first nodes did not have a marker. Take a look at this:

2. if there are hidden files in some directory after a node with markers, the marker doesn't get rendered, and I am just not sure how to deal with that.

• This is another example on how it looks with guide_level_start = 0 and with hide_root_node = false.

[sand4rt]

Do we really want the indentation marker to start from the node 0? / This is another example on how it looks with guide_level_start = 0

Yes, this is what the issue is about. I like how it looks. Perhaps this is fixable with an if opts.hide_root_node then ..

there are hidden files in some directory after a node with markers

Not sure either, could send what you already have? Maybe someone could help out with it?

[and-rs]

Alright if you like the node 0 implementation, I'd say we leave it like that, I don't even think a conditional would be necessary, and it would allow for more customization, anyone could decide if they want the indent marker from the node 0 with or without the root node hidden. I also recommend calling the option, marker_start_level just like the other options related to the indent marker.

I was wondering if I could commit directly to this PR branch, or if another PR is needed, I appreciate the guidance.

[sand4rt]

I was wondering if I could commit directly to this PR branch, or if another PR is needed

both is fine

[and-rs]

alright, I just made a new PR #1705 with the changes we discussed here. feel free to test them

[sand4rt]

closing in favour of: #1705