Repository navigation
refactor(bracketed): update diagnostic to not use deprecated methods - #2569
Conversation
There was a problem hiding this comment.
Thanks for the PR!
I used the code submitted in ... PR
That's a reasonable approach and what I was planning to do. This still needs adjustments to general 'mini.nvim' code approaches.
I made sure to never override a on_jump the user may have added to diagnostic.config
This requires new tests, I am afraid. And so should be a separate fix(bracketed) commit since.
8a923e7 to
37d9089
Compare
echasnovski
left a comment
There was a problem hiding this comment.
Looks almost done! Please separate into two commits, as I'd like to keep having refactor(xxx) commits to not change tests. The second fix(bracketed) can add a vim.diagnostic.config().jump.on_jump == nil check. And also two commits can have one Resolve #... instead of two.
37d9089 to
98e81a0
Compare
echasnovski
left a comment
There was a problem hiding this comment.
Looks good now! And two issues at once! Thanks again :)
While testing this, I found some strange issues with jumping logic, but it is also present on the main. Will take a look separately.
Resolve #2560
Resolve #2566
This PR uses
on_jumpinstead offloatwhen version >= 0.13I used the code submitted in this PR
I made sure to never override a
on_jumpthe user may have added todiagnostic.config