Skip to content

fix(extra): pass HOME to manpages picker spawn #2568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
echasnovski merged 1 commit into from
Oct 4, 2026
Merged

fix(extra): pass HOME to manpages picker spawn #2568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lua/mini/extra.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1283,6 +1283,7 @@ MiniExtra.pickers.manpages = function(local_opts, opts)
local env = { 'MANWIDTH=999' }
table.insert(env, vim.env.PATH ~= nil and ('PATH=' .. vim.env.PATH) or nil)
table.insert(env, vim.env.MANPATH ~= nil and ('MANPATH=' .. vim.env.MANPATH) or nil)
table.insert(env, vim.env.HOME ~= nil and ('HOME=' .. vim.env.HOME) or nil)
local source = { name = 'Manpages', choose = choose, preview = preview }
opts = vim.tbl_deep_extend('force', { source = source }, opts or {})
return pick.builtin.cli({ command = { 'man', '-k', '.' }, spawn_opts = { env = env } }, opts)
Expand Down
3 changes: 2 additions & 1 deletion tests/test_extra.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3243,12 +3243,13 @@ T['pickers']['manpages()']['works'] = function()
-- Should compute items with `man -k .` system call
child.fn.setenv('PATH', '/home,/home/user')
child.fn.setenv('MANPATH', '/home,/home/manpage')
child.fn.setenv('HOME', '/home/user')
child.lua_notify('_G.return_item = MiniExtra.pickers.manpages()')
validate_picker_name('Manpages')
child.expect_screenshot()

local cwd = child.fn.getcwd()
local spawn_env = { 'MANWIDTH=999', 'PATH=/home,/home/user', 'MANPATH=/home,/home/manpage' }
local spawn_env = { 'MANWIDTH=999', 'PATH=/home,/home/user', 'MANPATH=/home,/home/manpage', 'HOME=/home/user' }
eq(get_spawn_log(), { { executable = 'man', options = { args = { '-k', '.' }, cwd = cwd, env = spawn_env } } })
clear_spawn_log()
clear_process_log()
Expand Down
Loading