fix: remove formatting header keys for curl #628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conni2461
force-pushed
the
fix/curlHeader
branch
from
426c275 to
ede0782
Compare
|
thanks :) fix sounds good. i rebased the branch so i can run ci |
Conni2461
force-pushed
the
fix/curlHeader
branch
from
ede0782 to
57de0b8
Compare
Conni2461
force-pushed
the
fix/curlHeader
branch
from
57de0b8 to
6e090a3
Compare
|
i also fixed the failing test, although this is technically a breaking change. i agree that this behavior is wrong but other plugins might depend on this, not sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes formatting of header keys. This allows usage of the curl to have headers exactly as what users pass in