Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scandir): Consider global gitignore when forming ignore patterns #309

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

levouh
Copy link

@levouh levouh commented Jan 22, 2022

Still need to do some more testing, but the idea here is to support global ignore configuration on top of whatever is found within the directories of the given project.

Definitely some added overhead here as we now have to check not only local .gitignore files, but when we find nothing there we then have to check against every pattern in the global ignore as well. In my rather naive testing, the difference is not noticeable.

Some notes:

  1. Is it alright to use plenary.job here to check the existence of this file?
  2. Is there a preferred way to "run a job and get the output synchronously" beyond what I've done here?
  3. Is storing the global ignore under the key "" going to conflict with anyting?

@levouh levouh changed the title feat(scandir): Consider global gitignore when forming local ignore content feat(scandir): Consider global gitignore when forming ignore patterns Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant