feat(scandir): Consider global gitignore when forming ignore patterns #309
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to do some more testing, but the idea here is to support global ignore configuration on top of whatever is found within the directories of the given project.
Definitely some added overhead here as we now have to check not only local
.gitignore
files, but when we find nothing there we then have to check against every pattern in the global ignore as well. In my rather naive testing, the difference is not noticeable.Some notes:
plenary.job
here to check the existence of this file?""
going to conflict with anyting?