Skip to content

ci: skip lychee on pre-commit.ci - #18

Merged
bhashemian merged 1 commit into
mainfrom
devin/1793373099-precommit-ci-skip-lychee
Oct 30, 2026
Merged

bhashemian merged 1 commit into
mainfrom
devin/1793373099-precommit-ci-skip-lychee

Conversation

@bhashemian

@bhashemian bhashemian commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Summary

pre-commit.ci fails with "error during build" on every run since it was enabled, on main (24aaaab) and on any PR, documentation-only ones included (e.g. #17). The cause is the lychee hook. pre-commit.ci builds every hook environment before running any hooks. The lychee-bin==0.24.2 linux x86_64 wheel unpacks to a ~303 MiB bin/lychee binary, and the whole env is ~316 MiB. That is over pre-commit.ci's 250 MiB per-hook limit (pre-commit-ci/issues#171). The other hook envs are all under 45 MiB.

ci:
  skip: [lychee]

Lychee still runs on every PR in GitHub Actions (.github/workflows/ci.yml runs pre-commit run --all-files), and it still runs locally.

Verified with pre-commit validate-config and pre-commit run --all-files (all hooks pass).

Link to Devin session: https://nvidia-cloud.devinenterprise.com/sessions/144541c6824643eea6cd5a48fbf25ec6
Open in Devin Desktop: https://nvidia-cloud.devinenterprise.com/desktop/session/144541c6824643eea6cd5a48fbf25ec6?variant=devin
Requested by: @bhashemian


Devin Review

Summary by CodeRabbit

  • Chores
    • Updated the automated check workflow: link checking continues to run on every pull request, but is no longer run by pre-commit.ci. No end-user-facing changes are included in this update.

The lychee-bin hook environment (~300 MiB) exceeds pre-commit.ci's
250 MiB per-hook limit, so every pre-commit.ci run fails with
"error during build". GitHub Actions still runs lychee.

Signed-off-by: Bruce Hashemian <bhashemian@nvidia.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@coderabbitai

coderabbitai Bot commented Oct 30, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 758b6f46-ef0c-4f08-9198-325f6ed6074f
Commits

Reviewing files that changed from the base of the PR and between 24aaaab and c0fb82f.

Files selected for processing: 1
  • .pre-commit-config.yaml

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

Walkthrough

The pre-commit.ci configuration now skips the lychee hook. A comment states that GitHub Actions continues to run it on every pull request.

Changes

Pre-commit CI configuration

Layer / File(s) Summary
Skip lychee in pre-commit.ci
.pre-commit-config.yaml
A top-level ci.skip setting excludes the lychee hook from pre-commit.ci. A comment states that GitHub Actions continues to run it on every pull request.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Suggested reviewers: jjomier

Merge Risk: Minimal · up to c0fb8

The change correctly limits the skip to pre-commit.ci while retaining Lychee checks in GitHub Actions.

Pre-merge checks: Passed 4
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: skipping the lychee hook in pre-commit.ci.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@bhashemian
bhashemian merged commit 242ab57 into main Oct 30, 2026
3 checks passed
@bhashemian
bhashemian deleted the devin/1793373099-precommit-ci-skip-lychee branch October 30, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant