Repository navigation
ci: skip lychee on pre-commit.ci - #18
Merged
Merged
Conversation
The lychee-bin hook environment (~300 MiB) exceeds pre-commit.ci's 250 MiB per-hook limit, so every pre-commit.ci run fails with "error during build". GitHub Actions still runs lychee. Signed-off-by: Bruce Hashemian <bhashemian@nvidia.com> Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pre-commit.ci fails with "error during build" on every run since it was enabled, on
main(24aaaab) and on any PR, documentation-only ones included (e.g. #17). The cause is thelycheehook. pre-commit.ci builds every hook environment before running any hooks. Thelychee-bin==0.24.2linux x86_64 wheel unpacks to a ~303 MiBbin/lycheebinary, and the whole env is ~316 MiB. That is over pre-commit.ci's 250 MiB per-hook limit (pre-commit-ci/issues#171). The other hook envs are all under 45 MiB.Lychee still runs on every PR in GitHub Actions (
.github/workflows/ci.ymlrunspre-commit run --all-files), and it still runs locally.Verified with
pre-commit validate-configandpre-commit run --all-files(all hooks pass).Link to Devin session: https://nvidia-cloud.devinenterprise.com/sessions/144541c6824643eea6cd5a48fbf25ec6
Open in Devin Desktop: https://nvidia-cloud.devinenterprise.com/desktop/session/144541c6824643eea6cd5a48fbf25ec6?variant=devin
Requested by: @bhashemian
Summary by CodeRabbit