Skip to content

Use urn:holoscan metadata labels and validate tutorial metadata in CI - #15

Merged
bhashemian merged 2 commits into
mainfrom
devin/1792591019-holoscan-metadata-urn
Oct 21, 2026
Merged

bhashemian merged 2 commits into
mainfrom
devin/1792591019-holoscan-metadata-urn

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

Summary

Holoscan CLI 5.0.0 renamed the metadata schema IDs from urn:holohub: to urn:holoscan:, but three tutorials still carried the old label, and nothing in this repo validated metadata.json.

  • Labels: create-a-module, use-a-module, and rebot-gravity-compensation now use "$schema": "urn:holoscan:tutorial:v1".
  • Validation: a new local pre-commit hook, holoscan-metadata-validate, runs .github/scripts/validate_metadata.py on every metadata.json. The script is adapted from holoscan-applications. The hook installs holoscan-cli==5.0.0, jsonschema, and referencing into its own environment, so it uses the CLI's bundled schemas without a separate requirements file. The existing Validate tutorials workflow already runs pre-commit run --all-files, so the workflow file is unchanged.
  • Deprecated labels: a urn:holohub: label still passes, with the CLI's FutureWarning. Invalid JSON or a schema violation fails the hook.

Local checks:

  • pre-commit run --all-files passes.
  • With a urn:holohub: label put back, the hook passes and prints the warning.
  • With a required field removed, or with malformed JSON, the hook fails with exit code 1.

Link to Devin session: https://nvidia-cloud.devinenterprise.com/sessions/eb4d835f75bf4186b7be63c0a04979a2
Open in Devin Desktop: https://nvidia-cloud.devinenterprise.com/desktop/session/eb4d835f75bf4186b7be63c0a04979a2?variant=devin

tbirdso and others added 2 commits October 21, 2026 13:58
Replace the deprecated urn:holohub:tutorial:v1 labels with urn:holoscan:tutorial:v1, the schema ID shipped in Holoscan CLI 5.0.0.

Signed-off-by: Tom Birdsong <tbirdsong@nvidia.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Add a holoscan-metadata-validate pre-commit hook that checks each metadata.json against the schemas in the pinned holoscan-cli==5.0.0 wheel. CI already runs pre-commit on all files. Deprecated urn:holohub: labels still pass with the CLI's FutureWarning.

Signed-off-by: Tom Birdsong <tbirdsong@nvidia.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration
devin-ai-integration Bot marked this pull request as ready for review October 21, 2026 14:03
@tbirdso
tbirdso requested a review from bhashemian October 21, 2026 16:36
@tbirdso tbirdso self-assigned this Oct 21, 2026
@tbirdso
tbirdso requested a review from wyli October 21, 2026 16:37

@bhashemian bhashemian left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @tbirdso!

@bhashemian
bhashemian merged commit 29a1fed into main Oct 21, 2026
1 check passed
@bhashemian
bhashemian deleted the devin/1792591019-holoscan-metadata-urn branch October 21, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants