Repository navigation
Use urn:holoscan metadata labels and validate tutorial metadata in CI - #15
Merged
Merged
Conversation
Replace the deprecated urn:holohub:tutorial:v1 labels with urn:holoscan:tutorial:v1, the schema ID shipped in Holoscan CLI 5.0.0. Signed-off-by: Tom Birdsong <tbirdsong@nvidia.com> Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Add a holoscan-metadata-validate pre-commit hook that checks each metadata.json against the schemas in the pinned holoscan-cli==5.0.0 wheel. CI already runs pre-commit on all files. Deprecated urn:holohub: labels still pass with the CLI's FutureWarning. Signed-off-by: Tom Birdsong <tbirdsong@nvidia.com> Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
wyli
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Holoscan CLI 5.0.0 renamed the metadata schema IDs from
urn:holohub:tourn:holoscan:, but three tutorials still carried the old label, and nothing in this repo validatedmetadata.json.create-a-module,use-a-module, andrebot-gravity-compensationnow use"$schema": "urn:holoscan:tutorial:v1".holoscan-metadata-validate, runs.github/scripts/validate_metadata.pyon everymetadata.json. The script is adapted from holoscan-applications. The hook installsholoscan-cli==5.0.0,jsonschema, andreferencinginto its own environment, so it uses the CLI's bundled schemas without a separate requirements file. The existingValidate tutorialsworkflow already runspre-commit run --all-files, so the workflow file is unchanged.urn:holohub:label still passes, with the CLI'sFutureWarning. Invalid JSON or a schema violation fails the hook.Local checks:
pre-commit run --all-filespasses.urn:holohub:label put back, the hook passes and prints the warning.Link to Devin session: https://nvidia-cloud.devinenterprise.com/sessions/eb4d835f75bf4186b7be63c0a04979a2
Open in Devin Desktop: https://nvidia-cloud.devinenterprise.com/desktop/session/eb4d835f75bf4186b7be63c0a04979a2?variant=devin