Add loopback mode to ANO #699
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dylan Eustice <[email protected]>
Signed-off-by: Dylan Eustice <[email protected]>
Signed-off-by: Dylan Eustice <[email protected]>
dylan-eustice
force-pushed
the
deustice/loopback
branch
from
6b285d2 to
b654686
Compare
agirault
reviewed
Feb 21, 2025
applications/adv_networking_bench/adv_networking_bench_default_tx_rx.yaml
Outdated
Show resolved
Hide resolved
agirault
reviewed
Feb 21, 2025
applications/adv_networking_bench/adv_networking_bench_default_tx_rx.yaml
Outdated
Show resolved
Hide resolved
agirault
reviewed
Feb 21, 2025
applications/adv_networking_bench/adv_networking_bench_default_tx_rx.yaml
Outdated
Show resolved
Hide resolved
agirault
reviewed
Feb 21, 2025
applications/adv_networking_bench/adv_networking_bench_default_tx_rx.yaml
Outdated
Show resolved
Hide resolved
agirault
reviewed
Feb 21, 2025
applications/adv_networking_bench/adv_networking_bench_default_tx_rx_loopback.yaml
Outdated
Show resolved
Hide resolved
agirault
reviewed
Feb 21, 2025
agirault
reviewed
Feb 21, 2025
operators/advanced_network/managers/dpdk/adv_network_dpdk_mgr.cpp
Outdated
Show resolved
Hide resolved
operators/advanced_network/managers/dpdk/adv_network_dpdk_mgr.cpp
Outdated
Show resolved
Hide resolved
cliffburdick
approved these changes
Feb 21, 2025
Signed-off-by: Dylan Eustice <[email protected]>
Signed-off-by: Dylan Eustice <[email protected]>
Signed-off-by: Dylan Eustice <[email protected]>
Signed-off-by: Dylan Eustice <[email protected]>
dylan-eustice
force-pushed
the
deustice/loopback
branch
from
b654686 to
5eb0c6c
Compare
Signed-off-by: Dylan Eustice <[email protected]>
|
Hi @dylan-eustice, is this PR still in progress, or can we close it? Thanks. |
|
@bhashemian Sorry just seeing this. Yes, I feel like this is out-of-date enough to close. I can re-open if/when the need arises to integrate this feature into the newest version of Holoscan networking, but it would be too big of a lift right now and there's no immediate demand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Not functional with multi-queue RX