Add visual highlighting for web math navigation#20372
Draft
RyanMcCleary wants to merge 14 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Partially addresses #19191. To fully resolve that issue, we would want to implement highlighting for Microsoft Word as well.
Summary of the issue:
When navigating math, there is currently no visual highlighting showing the focused subpart. Visual highlighting is very useful for low-vision users and can make it easier to use speech and magnification together while reading math.
Description of user facing changes:
Adds a new highlighter for math, which highlights the currently focused subpart of the math being navigated in orange. I also considered making this part of the browse mode highlighter, and I'm still definitely open to suggestions on this front. I decided to leave it as a separate highlighter because math navigation is distinct from browse mode, even though it's usually activated from browse mode. I chose orange as the highlighting color because it's easier for me to see on a white background than yellow.
Description of developer facing changes:
Adds a new math highlight context to the vision framework and wires MathCAT navigation updates to it. The
MathCATInteractionclass now takes a source object as a constructor parameter (the source object is the root of the MathML being interacted with). A new filesource\mathPres\MathCAT\navNodeMapping.pywas also added. This file contains functions that are used to map from MathCAT's current navigation node to the corresponding IA2 object.Description of development approach:
Testing strategy:
Known issues with pull request:
Code Review Checklist: