Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Translation] Start translation to Portuguese Brazil (pt-br) #1988

Merged
merged 8 commits into from
Jan 19, 2022

Conversation

felipe-heredia
Copy link
Contributor

@felipe-heredia felipe-heredia commented Jan 14, 2022

Starting the Portuguese Brazil website translation (#1987).

Translated pages:

  • Index (including header and footer).
  • docs/1.get-started
  • docs/2.concepts/views

@netlify
Copy link

netlify bot commented Jan 14, 2022

‼️ Deploy request for nuxt rejected.
Learn more about Netlify's sensitive variable policy

🔨 Explore the source changes: a7007b4

Copy link
Collaborator

@ChristopheCVB ChristopheCVB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the time invested ;)

Copy link
Collaborator

@ChristopheCVB ChristopheCVB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last bit that I caught, otherwise, everything is perfect ;)

Copy link
Collaborator

@ChristopheCVB ChristopheCVB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@smarroufin smarroufin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please read #1777
This is not how content folder works, there are no locales in it, only languages. Only pt should exist.
Also do not update i18n configuration since someone from nuxtlabs will update it later.
For i18n/pt-br.js it is fine. 👌

@felipe-heredia
Copy link
Contributor Author

@smarroufin With the content folder working only with languages it will be impossible to have pt and pt-br. So I will close my pull request and stop my contributions.

Copy link
Contributor

@felipesuri Your i18n contribution is good, we could still merge it!
Depending on the future content improvements (by Docus), we might be able to merge this one day 🤞

@felipe-heredia
Copy link
Contributor Author

felipe-heredia commented Jan 18, 2022

@smarroufin Does Docus have a language limitation? Because it worked locally.

2022-01-18_11-08

Copy link
Contributor

@felipesuri Sorry about the inconvenience. I just talked about it with the Docus lead and it seems that there is no reason that it does not work. And you are showing that it is working well.
My bad then 😊 I invite you to reopen the PR, just remove the piece of config in nuxt.config.js and we are good to go!

@felipe-heredia
Copy link
Contributor Author

@smarroufin No problem, I removed pt-br config from nuxt.config.ts.

@smarroufin smarroufin merged commit 980e0f5 into nuxt:main Jan 19, 2022
Copy link
Contributor

Thanks @felipesuri 💚

felipe-heredia added a commit to felipe-heredia/nuxtjs.org that referenced this pull request Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants