docs: correct code example for nuxt-i18n when translations are lazy-loaded #5145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nuxt-i18n docs state that you are not supposed to directly change the value of locale. However, this was the case in the code example, because locale was passed to v-model which caused undesirable behavior. Specifically, this changed the locale before it was loaded from the server. This would result in a console error and the translation key rendering instead of the translation for a brief moment.
commit: |
benjamincanac
force-pushed
the
v4
branch
2 times, most recently
from
60e4da6 to
dc8040f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
The nuxt-i18n docs state that you are not supposed to directly change the value of locale. However, this was the case in the code example, because locale was passed to v-model which caused undesirable behavior. Specifically, this changed the locale before it was loaded from the server. This would result in a console error and the translation key rendering instead of the translation for a brief moment. The watch isn't strictly necessary, I suppose, but nice to ensure the state of locale and selectedLang always match.
📝 Checklist