Skip to content

feat(SelectMenu): add clearable icon to reset modelValue #3244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: v3
Choose a base branch
from

Conversation

emilsgulbis
Copy link

@emilsgulbis emilsgulbis commented Feb 5, 2025

πŸ”— Linked issue

Resolves #1057

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Added clear button to the SelectMenu

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@benjamincanac benjamincanac added the v3 #1289 label Feb 5, 2025
@emilsgulbis
Copy link
Author

hey @benjamincanac
tried my best for first time OS PR. If i need to make any adjustments - please let me know

@emilsgulbis
Copy link
Author

@benjamincanac Could you please give me some instructions to make this good to merge?

@rasyidly
Copy link

up, i really need this feature πŸš€

@hasan-ozbey
Copy link

what are we waiting for

@benjamincanac
Copy link
Member

Sorry for the delay on this, I've updated the PR and merged v3 but do note that this only works when the user actually provide a v-model, this is why I'd rather wait for Reka UI to implement this (unovue/reka-ui#1654).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Clear Button to USelectMenu
4 participants