Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Form): add standard schema support #2880

Merged
merged 7 commits into from
Feb 5, 2025

Conversation

Gerbuuun
Copy link
Contributor

πŸ”— Linked issue

resolves #2879

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Adds standard schema support to forms in UI v2

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@benjamincanac benjamincanac requested a review from romhml December 11, 2024 15:34
@Gerbuuun Gerbuuun changed the title feat: add standard schema support to UI v2 feat(Form): add standard schema support to UI v2 Dec 13, 2024
@romhml
Copy link
Collaborator

romhml commented Jan 2, 2025

Thanks @Gerbuuun! Your PR seems to work with standard schema, but I'm tempted to wait for valibot and standard-schema to release a stable v1 before merging into v2 to avoid breaking changes.

I also tested the example in the docs with [email protected] and it seems to work:

https://stackblitz.com/edit/nuxt-ui-n8u64pe4?file=app.vue

@Gerbuuun
Copy link
Contributor Author

Gerbuuun commented Jan 2, 2025

Totally understand. For now I have it patched so it's not a blocker for me!

@benjamincanac
Copy link
Member

I guess we can now use https://github.com/standard-schema/standard-schema/releases/tag/v1.0.0 right?

@Gerbuuun
Copy link
Contributor Author

Gerbuuun commented Feb 3, 2025

Updated to @standard-schema/spec v1 and fixed a typo. I think it's good to go!

edit: I see a lot of additions in the package-lock. also I broke the types...

@Gerbuuun
Copy link
Contributor Author

Gerbuuun commented Feb 4, 2025

@benjamincanac everything seems good now!

@benjamincanac benjamincanac requested review from romhml and removed request for romhml February 4, 2025 13:17
@benjamincanac benjamincanac changed the title feat(Form): add standard schema support to UI v2 feat(Form): add standard schema support Feb 5, 2025
@benjamincanac benjamincanac merged commit 9c36d37 into nuxt:dev Feb 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants