-
Notifications
You must be signed in to change notification settings - Fork 53
chore(deps): update actions/setup-node action to v6 #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
renovate
wants to merge
1
commit into
main
Choose a base branch
from
renovate/actions-setup-node-6.x
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
actions/setup-nodeaction is using a floating version tag (@v6) instead of a pinned commit hash, which is inconsistent with the approach used inci.ymland introduces non-deterministic workflow behavior.View Details
Analysis
Inconsistent GitHub Actions version pinning in playwright.yml
What fails:
.github/workflows/playwright.ymlline 21 uses a floating version tagactions/setup-node@v6instead of a pinned commit hash, inconsistent withci.ymlwhich usesactions/setup-node@395ad3262231945c25e8478fd5baf05154b1d79f # v6.1.0How to reproduce: Examine the workflow files:
ci.yml: Uses pinned commit hash format for all actions (e.g.,actions/setup-node@395ad3262231945c25e8478fd5baf05154b1d79f # v6.1.0)playwright.yml: Line 21 uses floating tagactions/setup-node@v6Result: Floating version tags resolve to the latest matching release at workflow runtime, causing non-deterministic behavior where different workflow runs may execute different patch versions of the action.
Expected: All workflows should use pinned commit hashes per GitHub's official security recommendation that "pinning an action to a full-length commit SHA is currently the only way to use an action as an immutable release." This prevents tag mutation attacks and ensures reproducible CI runs.
Fix applied: Updated line 21 to use the same pinned commit hash as ci.yml:
actions/setup-node@395ad3262231945c25e8478fd5baf05154b1d79f # v6.1.0