Skip to content

fix(init): skip modules that are dependencies of the selected template #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

HugoRCD
Copy link
Member

@HugoRCD HugoRCD commented Jun 10, 2025

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Before:

CleanShot.2025-06-12.at.10.33.24.mp4

After:

CleanShot.2025-06-12.at.10.32.00.mp4

@HugoRCD HugoRCD marked this pull request as ready for review June 10, 2025 18:25
@HugoRCD HugoRCD requested a review from danielroe as a code owner June 10, 2025 18:25
Copy link

pkg-pr-new bot commented Jun 10, 2025

Open in StackBlitz

npm i https://pkg.pr.new/create-nuxt@910
npm i https://pkg.pr.new/nuxi@910
npm i https://pkg.pr.new/@nuxt/cli@910

commit: cc61722

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 60 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@4ac8e3d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
packages/nuxi/src/commands/init.ts 0.00% 60 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #910   +/-   ##
=======================================
  Coverage        ?   12.78%           
=======================================
  Files           ?       71           
  Lines           ?     3769           
  Branches        ?      108           
=======================================
  Hits            ?      482           
  Misses          ?     3255           
  Partials        ?       32           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

codspeed-hq bot commented Jun 10, 2025

CodSpeed Performance Report

Merging #910 will not alter performance

Comparing HugoRCD:fix-init-template-deps (cc61722) with main (4ac8e3d)

Summary

βœ… 2 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants