Turn back on line-numbers #1579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I would certainly love to turn line-numbers off (or at least only use them when there's a certain number of lines in the code-block), as mentioned in #1573 this just doesn't seem to work in Vuepress at the moment when using Shiki. Attempting to turn them off makes the problem worse by only removing the line-number from the last line, while keeping the rest:
This PR turns them back on to at least fix that bug. I don't yet know what the long-term solution should be.
It seems odd to me that this is broken at the Vuepress/Shiki upstream, but as mentioned in #1573, I reproduced it in a clean environment.