Fixes broken links #1540
Merged
Fixes broken links #1540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The breaking changes were split up at some point in two sections but the internal link wasn't updated. This is now pointing at the full list of breaking changes again.
sholderbach
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Thanks for the fix.
I personally think that the All breaking changes section we have now just containing the commits is not that helpful and we should try to contain the small explanations of the changes under a breaking changes section going forward, so things that need manual updating are centralized.
|
I can update the links to point to that other link if you prefer? https://www.nushell.sh/blog/2024-08-20-nushell_0_97_1.html#breaking-changes-toc I'll leave the decision up to you and going forward things can be changed anyway, yeah. |
|
That was more a comment for future authors of release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The breaking changes were split up at some point in two sections but the internal link wasn't updated. This is now pointing at the full list of breaking changes again.