Port before_v0.60/data_extraction before_v0.60/examples before_v0.60/duplicates#847
Merged
fdncred merged 9 commits intonushell:mainfrom May 26, 2024
Conversation
This script is already ported to `modules/data_extraction/ultimate_extractor.nu`
- `empty?` -> `is-empty` - `pivot` -> `transpose` - `Column1` -> `column1` - implicit `it` -> `in`
- add `print` - add `source duplicates.nu` - remove `echo`
- replace all '-' with '_'
- `keep until` -> `take until`
- explicit `$it`
- `str collect` -> `str join`
- `str find-replace` -> `str replace`
- "\[ \]" -> to the raw '\[ \]'
- `if {} {}` -> `if {} else {}`
- explicit print
- embed the `core-team` table, remove `assets/core_team.nu` - embed the `date local` function from `language/std/date` - explicit print - `str collect` -> `str join` - `$block` -> `$closure` - `date format` -> `format date`
Contributor
|
modules need to have exported custom commands, sourced do not. |
- rename `duplicates.nu` into `mod.nu` - add export keywords
Contributor
Author
|
|
Contributor
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of porting all old scripts #221 and includes a set of modules:
data_extractionexamplesduplicates7 changed files:
data_extractiondata_extraction/ultimate_extractor.nu: removed. Has already been ported tomodules/data_extraction/ultimate_extractor.nuduplicatesduplicates/duplicates.nu->modules/duplicates/duplicates.nuduplicates/example.nu->modules/duplicates/example.nuduplicates/README.md->modules/duplicates/README.md: unchangedexamplesexamples/netstat.nu->modules/examples/netstat.nuexamples/date_in_local_timezones.nu->modules/examples/date_in_local_timezones.nubefove_v0.60/assets/core_team.nu: removed. This table has been embedded intodate_in_local_timezones.nu